Created attachment 172010 [details] Patch

Comment on attachment 172010 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172010&action=review > Source/WebCore/ChangeLog:8 > + Panels, that hasn't been shown at the moment when shortcuts Consider rephrasing: .. that have not been loaded by the time shortcuts view was .. > Source/WebCore/inspector/front-end/ShortcutsScreen.js:35 > +WebInspector.ShortcutsScreen = function(registrationCallback) registrationCallback sounds weird too generic. > Source/WebCore/inspector/front-end/inspector.js:653 > + panelDescriptors[i].panel(); We should not create panels just to register their shortcuts. Instead, shortcut declaration code should be moved into the panel descriptors.

Created attachment 172547 [details] Patch

Created attachment 172548 [details] Patch

Comment on attachment 172010 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172010&action=review >> Source/WebCore/ChangeLog:8 >> + Panels, that hasn't been shown at the moment when shortcuts > > Consider rephrasing: .. that have not been loaded by the time shortcuts view was .. Done. >> Source/WebCore/inspector/front-end/ShortcutsScreen.js:35 >> +WebInspector.ShortcutsScreen = function(registrationCallback) > > registrationCallback sounds weird too generic. Removed. >> Source/WebCore/inspector/front-end/inspector.js:653 >> + panelDescriptors[i].panel(); > > We should not create panels just to register their shortcuts. Instead, shortcut declaration code should be moved into the panel descriptors. Fixed.

Comment on attachment 172548 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172548&action=review > Source/WebCore/ChangeLog:14 > + More chanhes: add JsDoc annotations to ShortcutScreen and change "key" typo: chanhes-> changes > Source/WebCore/inspector/front-end/ElementsPanelDescriptor.js:76 > + var incrementBy10 = WebInspector.ElementsPanelDescriptor.ShortcutKeys.IncrementValue.concat(WebInspector.ElementsPanelDescriptor.ShortcutKeys.DecrementValue); Remove this line. > Source/WebCore/inspector/front-end/ElementsPanelDescriptor.js:79 > + stylesPaneSection.addAlternateKeys(WebInspector.ElementsPanelDescriptor.ShortcutKeys.DecrementBy10, WebInspector.UIString("Decrement by %f", 10)); We should be consistent and use single entry "Increment/Decrement by 10" here as for 0.1 and 100 > Source/WebCore/inspector/front-end/ElementsPanelDescriptor.js:81 > + var incrementDecrementBy100 = WebInspector.ElementsPanelDescriptor.ShortcutKeys.IncrementBy01.concat(WebInspector.ElementsPanelDescriptor.ShortcutKeys.DecrementBy01); incrementDecrementBy100 -> incrementDecrementBy01 > Source/WebCore/inspector/front-end/ElementsPanelDescriptor.js:84 > + var incrementDecrementBy01 = WebInspector.ElementsPanelDescriptor.ShortcutKeys.IncrementBy100.concat(WebInspector.ElementsPanelDescriptor.ShortcutKeys.DecrementBy100); incrementDecrementBy01 -> incrementDecrementBy100. Looks like there is a mistake in shortcut description for .1 and 100

Comment on attachment 172548 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172548&action=review >> Source/WebCore/ChangeLog:14 >> + More chanhes: add JsDoc annotations to ShortcutScreen and change "key" > > typo: chanhes-> changes Done. >> Source/WebCore/inspector/front-end/ElementsPanelDescriptor.js:76 >> + var incrementBy10 = WebInspector.ElementsPanelDescriptor.ShortcutKeys.IncrementValue.concat(WebInspector.ElementsPanelDescriptor.ShortcutKeys.DecrementValue); > > Remove this line. Done. >> Source/WebCore/inspector/front-end/ElementsPanelDescriptor.js:79 >> + stylesPaneSection.addAlternateKeys(WebInspector.ElementsPanelDescriptor.ShortcutKeys.DecrementBy10, WebInspector.UIString("Decrement by %f", 10)); > > We should be consistent and use single entry "Increment/Decrement by 10" here as for 0.1 and 100 Fixed. >> Source/WebCore/inspector/front-end/ElementsPanelDescriptor.js:81 >> + var incrementDecrementBy100 = WebInspector.ElementsPanelDescriptor.ShortcutKeys.IncrementBy01.concat(WebInspector.ElementsPanelDescriptor.ShortcutKeys.DecrementBy01); > > incrementDecrementBy100 -> incrementDecrementBy01 Fixed. >> Source/WebCore/inspector/front-end/ElementsPanelDescriptor.js:84 >> + var incrementDecrementBy01 = WebInspector.ElementsPanelDescriptor.ShortcutKeys.IncrementBy100.concat(WebInspector.ElementsPanelDescriptor.ShortcutKeys.DecrementBy100); > > incrementDecrementBy01 -> incrementDecrementBy100. Looks like there is a mistake in shortcut description for .1 and 100 Fixed.

Created attachment 172969 [details] Patch

Comment on attachment 172969 [details] Patch Rejecting attachment 172969 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: rging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 [Qt] Unreviewed Qt gardening. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 154. Full output: http://queues.webkit.org/results/14824260

Created attachment 173857 [details] Patch rebased

Comment on attachment 173857 [details] Patch Clearing flags on attachment: 173857 Committed r134404: <http://trac.webkit.org/changeset/134404>

Comment on attachment 172969 [details] Patch Cleanup after commit

Reopened since it was rolled out