Bug 96778

Summary: [GTK] Don't use the C API internally in WebKitGeolocation classes
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cabanier, gustavo, mario, mrobinson
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on: 96777    
Bug Blocks: 96766, 96779    
Attachments:
Description Flags
Patch
none
Updated patch to build on current git master gustavo: review+

Carlos Garcia Campos
Reported 2012-09-14 07:09:00 PDT
Use the C++ classes instead.
Attachments
Patch (10.98 KB, patch)
2012-09-14 07:10 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated patch to build on current git master (11.08 KB, patch)
2012-10-16 01:38 PDT, Carlos Garcia Campos 		gustavo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2012-09-14 07:10:26 PDT
Created attachment 164139 [details] Patch
Mario Sanchez Prada
Comment 2 2012-10-03 01:44:15 PDT
Comment on attachment 164139 [details] Patch Looks good to me
Carlos Garcia Campos
Comment 3 2012-10-16 01:38:39 PDT
Created attachment 168890 [details] Updated patch to build on current git master Updated after WebGeolocationPosition::create() API change
Rik Cabanier
Comment 4 2012-10-16 08:46:27 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 5 2012-10-17 08:24:31 PDT
Committed r131598: <http://trac.webkit.org/changeset/131598>
Note You need to log in before you can comment on or make changes to this bug.