Bug 239038

Summary: [GTK][WPE] Provide WK2 IPC encoding, decoding methods for the DMABufObject type
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 238740    
Bug Blocks: 237649    
Attachments:
Description Flags
WIP patch
none
Patch
none
Patch none

Zan Dobersek
Reported 2022-04-09 13:25:22 PDT
[GTK][WPE] Provide WK2 IPC encoding, decoding methods for the DMABufObject type
Attachments
WIP patch (4.09 KB, patch)
2022-04-09 13:25 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (4.62 KB, patch)
2022-04-10 23:08 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (4.85 KB, patch)
2022-04-12 09:15 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2022-04-09 13:25:44 PDT
Created attachment 457179 [details] WIP patch
Zan Dobersek
Comment 2 2022-04-10 23:08:32 PDT
Created attachment 457232 [details] Patch
Zan Dobersek
Comment 3 2022-04-12 09:15:10 PDT
Created attachment 457335 [details] Patch Added missing <optional> include.
Adrian Perez
Comment 4 2022-04-13 09:08:22 PDT
Comment on attachment 457335 [details] Patch Patch LGTM, modulo fixing the style checker issues before landing :)
Zan Dobersek
Comment 5 2022-04-14 07:11:08 PDT
(In reply to Adrian Perez from comment #4) > Comment on attachment 457335 [details] > Patch > > Patch LGTM, modulo fixing the style checker issues before landing :) Can't, the style checker doesn't handle ref qualifiers.
Zan Dobersek
Comment 6 2022-04-14 07:13:51 PDT
Comment on attachment 457335 [details] Patch Clearing flags on attachment: 457335 Committed r292864 (249635@trunk): <https://commits.webkit.org/249635@trunk>
Zan Dobersek
Comment 7 2022-04-14 07:13:56 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2022-04-14 07:14:18 PDT
<rdar://problem/91751419>
Adrian Perez
Comment 9 2022-04-14 11:03:15 PDT
(In reply to Zan Dobersek from comment #5) > (In reply to Adrian Perez from comment #4) > > Comment on attachment 457335 [details] > > Patch > > > > Patch LGTM, modulo fixing the style checker issues before landing :) > > Can't, the style checker doesn't handle ref qualifiers. Ah, pity.
Note You need to log in before you can comment on or make changes to this bug.