Bug 224829

Summary: If an idle GPUProcess doesn't exit under memory pressure because it just launched, check again later
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ggaren, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 224798    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2021-04-20 14:23:38 PDT
If an idle GPUProcess doesn't exit under memory pressure because it just launched, check again later. This is a follow-up to r276305.
Attachments
Patch (5.29 KB, patch)
2021-04-20 14:33 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (5.99 KB, patch)
2021-04-20 15:32 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (5.84 KB, patch)
2021-04-20 15:36 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-04-20 14:33:46 PDT
Created attachment 426594 [details] Patch
Darin Adler
Comment 2 2021-04-20 15:16:55 PDT
Comment on attachment 426594 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426594&action=review > Source/WebKit/GPUProcess/GPUProcess.cpp:155 > return true; Should we do m_idleExitTimer.stop() here too?
Chris Dumez
Comment 3 2021-04-20 15:19:36 PDT
Comment on attachment 426594 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426594&action=review >> Source/WebKit/GPUProcess/GPUProcess.cpp:155 >> return true; > > Should we do m_idleExitTimer.stop() here too? Hmm. In this case, we will end up exiting anyway, but sure, it feels a bit cleaner to stop the timer in this case too.
Chris Dumez
Comment 4 2021-04-20 15:32:23 PDT
Created attachment 426600 [details] Patch
Chris Dumez
Comment 5 2021-04-20 15:36:51 PDT
Created attachment 426602 [details] Patch
Chris Dumez
Comment 6 2021-04-20 15:38:37 PDT
I made the suggested change. I am asking for review again because I made a significant change. I moved the whole logic from canExitUnderMemoryPressure() to tryExitIfUnused(). It feels much nicer for tryExitIfUnused() to schedule a timer to call tryExitIfUnused() then a simple query function like canExitUnderMemoryPressure().
EWS
Comment 7 2021-04-20 17:59:00 PDT
Committed r276339 (236817@main): <https://commits.webkit.org/236817@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426602 [details].
Radar WebKit Bug Importer
Comment 8 2021-04-23 01:23:08 PDT
<rdar://problem/77061558>
Note You need to log in before you can comment on or make changes to this bug.