Bug 207906

Summary: Build failure on ppc64le if __unix is undefined
Product: WebKit Reporter: Mike Gorse <mgorse>
Component: bmallocAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, mgorse, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch. none

Mike Gorse
Reported 2020-02-18 13:05:46 PST
I'm getting a build failure building webkitgtk for ppc64le on SLE 15 (gcc 7.5.0). __unix is undefined when building with -std=c++1z (but only on ppc64le, apparently), so BOS_UNIX doesn't get defined, leading to some headers not being included later. __unix__ is defined.
Attachments
Patch. (882 bytes, patch)
2020-02-18 13:18 PST, Mike Gorse 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike Gorse
Comment 1 2020-02-18 13:18:47 PST
Created attachment 391081 [details] Patch.
Yusuke Suzuki
Comment 2 2020-03-09 00:18:49 PDT
Comment on attachment 391081 [details] Patch. r=me
WebKit Commit Bot
Comment 3 2020-03-09 08:25:23 PDT
Comment on attachment 391081 [details] Patch. Clearing flags on attachment: 391081 Committed r258142: <https://trac.webkit.org/changeset/258142>
WebKit Commit Bot
Comment 4 2020-03-09 08:25:24 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2020-03-09 08:26:19 PDT
<rdar://problem/60223932>
Note You need to log in before you can comment on or make changes to this bug.