Bug 204705

Summary: [GTK][WPE] Add libuuid to install-dependencies
Product: WebKit Reporter: Patrick Griffis <pgriffis>
Component: WebKitGTKAssignee: Patrick Griffis <pgriffis>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, aperez, bugs-noreply, clopez, commit-queue, ews-feeder, ews-watchlist, ltilve
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Patrick Griffis
Reported 2019-11-29 09:17:41 PST
[GTK][WPE] Add libuuid to install-dependencies
Attachments
Patch (1.44 KB, patch)
2019-11-29 09:18 PST, Patrick Griffis 		no flags
DetailsFormatted DiffDiff
Patch (2.01 KB, patch)
2019-11-29 09:19 PST, Patrick Griffis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick Griffis
Comment 1 2019-11-29 09:18:04 PST
Created attachment 384512 [details] Patch
Patrick Griffis
Comment 2 2019-11-29 09:19:52 PST
Created attachment 384513 [details] Patch
Adrian Perez
Comment 3 2019-11-29 09:26:29 PST
Comment on attachment 384513 [details] Patch Patch LGTM, but please add “libutil-linux” to the list of packages needed on Arch Linux (in “installDependenciesWithPacman“) before landing.
Adrian Perez
Comment 4 2019-11-29 09:28:24 PST
(In reply to Adrian Perez from comment #3) > Comment on attachment 384513 [details] > Patch > > Patch LGTM, but please add “libutil-linux” to the list of packages > needed on Arch Linux (in “installDependenciesWithPacman“) before > landing. Forget about this. The “util-linux” package is already in the list, which depends on “libutil-linux” itself anyway — nothing else is needed for Arch. Please land the patch as-is.
EWS
Comment 5 2019-12-02 09:38:09 PST
Comment on attachment 384513 [details] Patch Rejecting attachment 384513 [details] from commit-queue. pgriffis@igalia.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Commit Bot
Comment 6 2019-12-04 05:12:43 PST
Comment on attachment 384513 [details] Patch Clearing flags on attachment: 384513 Committed r253101: <https://trac.webkit.org/changeset/253101>
WebKit Commit Bot
Comment 7 2019-12-04 05:12:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.