Bug 200520

Summary:

Web Inspector: rename `queryObjects` to `queryInstances` for clarity

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, nvasilyev, rniwa, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

176766

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-highsierra	none
Archive of layout-test-results from ews114 for mac-highsierra	none
Patch	none

Devin Rousso

Reported 2019-08-07 15:55:23 PDT

`Objects` could really refer to anything, whereas `Instances` is MUCH clearer and more self explanatory. We should still keep an "alias" from `queryObjects` to `queryInstances` so that existing users aren't affected.

Attachments
Patch (60.98 KB, patch) 2019-08-07 15:59 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-highsierra (3.19 MB, application/zip) 2019-08-07 17:08 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-highsierra (3.04 MB, application/zip) 2019-08-07 17:58 PDT, EWS Watchlist	no flags	Details
Patch (62.32 KB, patch) 2019-08-07 19:39 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2019-08-07 15:59:54 PDT

Created attachment 375760 [details] Patch

Nikita Vasilyev

Comment 2 2019-08-07 16:04:51 PDT

Do the other browsers (*cough cough* Chromium) plan to rename queryObjects as well? It does seem like a better name.

Devin Rousso

Comment 3 2019-08-07 16:07:38 PDT

(In reply to Nikita Vasilyev from comment #2) > Do the other browsers (*cough cough* Chromium) plan to rename queryObjects as well? It does seem like a better name. Not that I'm aware. This is another reason why I'm keeping an alias :P

EWS Watchlist

Comment 4 2019-08-07 17:08:44 PDT Comment hidden (obsolete)

Comment on attachment 375760 [details] Patch Attachment 375760 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12876222 New failing tests: http/tests/inspector/dom/cross-domain-inspected-node-access.html

EWS Watchlist

Comment 5 2019-08-07 17:08:46 PDT Comment hidden (obsolete)

Created attachment 375768 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 6 2019-08-07 17:58:08 PDT Comment hidden (obsolete)

Comment on attachment 375760 [details] Patch Attachment 375760 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12876290 New failing tests: http/tests/inspector/dom/cross-domain-inspected-node-access.html

EWS Watchlist

Comment 7 2019-08-07 17:58:10 PDT Comment hidden (obsolete)

Created attachment 375772 [details] Archive of layout-test-results from ews114 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6

Devin Rousso

Comment 8 2019-08-07 19:39:35 PDT

Created attachment 375780 [details] Patch

Blaze Burg

Comment 9 2019-08-08 11:09:37 PDT

Comment on attachment 375780 [details] Patch r=me

WebKit Commit Bot

Comment 10 2019-08-08 11:59:10 PDT

Comment on attachment 375780 [details] Patch Clearing flags on attachment: 375780 Committed r248434: <https://trac.webkit.org/changeset/248434>

WebKit Commit Bot

Comment 11 2019-08-08 11:59:12 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 12 2019-08-08 12:00:26 PDT

<rdar://problem/54090116>

Note You need to log in before you can comment on or make changes to this bug.