Bug 187336

Summary: REGRESSION(r233495) [cairo] drawGlyphsShadow should use the fast path for zero blur-radius
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: WebKitGTKAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, cgarcia, ews-watchlist, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews205 for win-future none

Fujii Hironori
Reported 2018-07-05 01:03:35 PDT
REGRESSION(r233495) [cairo] drawGlyphsShadow should use the fast path for zero blur-radius drawGlyphsShadow has a fast path to draw a shadow without a shadow layer. Since r233495, it is not used for zero blur-radius shadow. In Bug 187244, I changed ShadowState::isRequired to return true for zero blur-radius. This is not a right fix.
Attachments
Patch (4.13 KB, patch)
2018-07-05 01:30 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews205 for win-future (12.79 MB, application/zip)
2018-07-05 05:30 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2018-07-05 01:30:34 PDT
Created attachment 344312 [details] Patch
EWS Watchlist
Comment 2 2018-07-05 05:30:13 PDT
Comment on attachment 344312 [details] Patch Attachment 344312 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8443647 New failing tests: http/tests/security/video-poster-cross-origin-crash2.html
EWS Watchlist
Comment 3 2018-07-05 05:30:25 PDT
Created attachment 344321 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Fujii Hironori
Comment 4 2018-07-05 18:57:17 PDT
Comment on attachment 344312 [details] Patch Clearing flags on attachment: 344312 Committed r233556: <https://trac.webkit.org/changeset/233556>
Fujii Hironori
Comment 5 2018-07-05 18:57:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.