Bug 153120

Summary: [GTK OSX] libwebkit2gtk fails to link due to missing symbol ANGLEPlatformCurrent
Product: WebKit Reporter: Jeremy Huddleston Sequoia <jeremyhu>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bugs-noreply, commit-queue, mcatanzaro, mrobinson
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126492    
Attachments:
Description Flags
patch
none
patch
darin: review+, commit-queue: commit-queue-
Updated patch with ChangeLog entry
none
Archive of layout-test-results from ews117 for mac-yosemite none

Jeremy Huddleston Sequoia
Reported 2016-01-15 00:38:24 PST
After working around bug #152720 and bug #153117, libwebkit2gtk-4.0.37.dylib fails to link when configured with ENABLE_GRAPHICS_CONTEXT_3D due to missing ANGLEPlatformCurrent() required by libANGLESupport.a Undefined symbols for architecture x86_64: "ANGLEPlatformCurrent()", referenced from: angle::GetTraceCategoryEnabledFlag(char const*) in libANGLESupport.a(event_tracer.cpp.o) angle::AddTraceEvent(char, unsigned char const*, char const*, unsigned long long, int, char const**, unsigned char const*, unsigned long long const*, unsigned char) in libANGLESupport.a(event_tracer.cpp.o) ANGLEPlatformCurrent() is defined in Source/ThirdParty/ANGLE/src/libANGLE/Platform.cpp, but that file is not included in ANGLESupport_SOURCES in Source/WebCore/CMakeLists.txt Should the build system be building libANGLE? It looks like it does that for the Win32 case.
Attachments
patch (1.12 KB, patch)
2016-01-15 08:41 PST, Jeremy Huddleston Sequoia 		no flags
DetailsFormatted DiffDiff
patch (544 bytes, patch)
2016-01-15 16:21 PST, Jeremy Huddleston Sequoia 		darin: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Updated patch with ChangeLog entry (1.64 KB, patch)
2016-01-15 23:12 PST, Jeremy Huddleston Sequoia 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews117 for mac-yosemite (812.53 KB, application/zip)
2016-01-16 00:54 PST, Build Bot 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2016-01-15 06:57:57 PST
(In reply to comment #0) > Should the build system be building libANGLE? It looks like it does that > for the Win32 case. It needs to build some of ANGLE on all platforms, but it builds more of it on Windows than it does on Linux and OS X. I think Martin or Alex might know more.
Jeremy Huddleston Sequoia
Comment 2 2016-01-15 08:41:51 PST
Created attachment 269058 [details] patch Yep, that did the trick. Patch attached.
Jeremy Huddleston Sequoia
Comment 3 2016-01-15 08:42:24 PST
Ignore the above. Commented in wrong bug.
Jeremy Huddleston Sequoia
Comment 4 2016-01-15 08:45:06 PST
Should we be adding Platform.cpp to ANGLESupport then?
Jeremy Huddleston Sequoia
Comment 5 2016-01-15 16:21:32 PST
Created attachment 269116 [details] patch Patch to add Platform.cpp to ANGLESupport. This allowed the build to succeed for me.
WebKit Commit Bot
Comment 6 2016-01-15 17:14:09 PST
Comment on attachment 269116 [details] patch Rejecting attachment 269116 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 269116, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 195158 = 5e0ec89178c50a38ebca33d1b802e472421349f9 r195159 = 15508cbafa592ada83ca8fc3ac951d3c9c7b68c8 r195160 = b60e2997410b19de712975d1ed475259837d146b Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/696316
Michael Catanzaro
Comment 7 2016-01-15 18:45:20 PST
Hm, I thought the bot had a nicer error message for this... anyway, the problem is the patch does not have a changelog entry. You can create a changelog entry template by running Tools/Scripts/prepare-ChangeLog. See https://webkit.org/contributing-code/#changelogs for details. Thanks!
Jeremy Huddleston Sequoia
Comment 8 2016-01-15 23:12:46 PST
Created attachment 269156 [details] Updated patch with ChangeLog entry
Build Bot
Comment 9 2016-01-16 00:54:45 PST
Comment on attachment 269156 [details] Updated patch with ChangeLog entry Attachment 269156 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/697700 New failing tests: imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html
Build Bot
Comment 10 2016-01-16 00:54:48 PST
Created attachment 269161 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Michael Catanzaro
Comment 11 2016-01-16 07:56:37 PST
Comment on attachment 269156 [details] Updated patch with ChangeLog entry Hm, a flaky test... now you're just getting unlucky! (Please only set r+ if you're a reviewer; you don't need to set it when uploading a patch that already has the reviewed-by line.)
WebKit Commit Bot
Comment 12 2016-01-16 08:46:16 PST
Comment on attachment 269156 [details] Updated patch with ChangeLog entry Clearing flags on attachment: 269156 Committed r195169: <http://trac.webkit.org/changeset/195169>
WebKit Commit Bot
Comment 13 2016-01-16 08:46:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.