Bug 150799

Summary: [Mac][GTK] Jhbuild support for OSX
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro, philip.chimento
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126492    
Attachments:
Description Flags
Patch
none
updated patch
none
same patch
none
updated patch mcatanzaro: review+

Philippe Normand
Reported 2015-11-02 06:27:02 PST
Some modules depend on X11 so let's disable them on OSX. If we want to run layout tests on that platform, something will need to be figured out to not depend on Xvfb though.
Attachments
Patch (16.85 KB, patch)
2015-11-02 06:34 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
updated patch (18.33 KB, patch)
2015-12-05 07:52 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
same patch (18.33 KB, patch)
2015-12-07 02:08 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
updated patch (16.29 KB, patch)
2015-12-08 02:28 PST, Philippe Normand 		mcatanzaro: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2015-11-02 06:34:42 PST
Created attachment 264582 [details] Patch
Michael Catanzaro
Comment 2 2015-11-02 07:23:46 PST
I'd like to see two improvements here: * Instead of splitting the OS X and Linux dependencies into separate modulesets, I'd like to have just the one moduleset with platform conditionals instead. * Instead of using module_autogenargs and module_makeargs in the jhbuildrc file (intended to be used for user-specific configuration, not configuration necessary to make the modules build at all), the autogenargs and makeargs should be specified in the modulesets file. Example: https://git.gnome.org/browse/jhbuild/tree/modulesets/gnome-suites-core-deps-3.20.modules#n425 Documentation: " https://developer.gnome.org/jhbuild/unstable/moduleset-syntax.html.en You might need to upgrade the jhbuild version to get conditionals; see bug #145697 for an example.
Philippe Normand
Comment 3 2015-11-02 07:26:30 PST
Ah, I had no idea about this feature :) I'll rework the patch, thanks for the suggestions, Michael!
Philip Chimento
Comment 4 2015-11-02 09:04:10 PST
Comment on attachment 264582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264582&action=review > Tools/gtk/jhbuild.modules:-249 > - autogenargs="--disable-introspection"> --disable-introspection and --enable-introspection=no should be just the same, right?
Philippe Normand
Comment 5 2015-11-06 04:38:52 PST
Seems like this doesn't work for makeargs tuning :/
Philippe Normand
Comment 6 2015-12-05 07:52:50 PST
Created attachment 266715 [details] updated patch
Philippe Normand
Comment 7 2015-12-07 02:08:23 PST
Created attachment 266757 [details] same patch For EWS.
Philippe Normand
Comment 8 2015-12-08 02:28:08 PST
Created attachment 266868 [details] updated patch
Michael Catanzaro
Comment 9 2015-12-22 07:00:11 PST
Comment on attachment 266868 [details] updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=266868&action=review > Tools/gtk/jhbuild.modules:75 > + <autotools id="cairo" makeargs=""> Do you need the makeargs=""? I think that is for appending, not overriding, so I guess it does nothing.
Philippe Normand
Comment 10 2015-12-30 00:34:07 PST
Committed r194444: <http://trac.webkit.org/changeset/194444>
Note You need to log in before you can comment on or make changes to this bug.