Bug 147299

Summary: aria-liveregions-notifications tests are very flaky
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=147211
Attachments:
Description Flags
patch
cfleizach: review-
patch none

Alexey Proskuryakov
Reported 2015-07-25 18:00:13 PDT
aria-liveregions-notifications tests are very flaky, failing most of the time on debug bots: https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=platform%2Fmac%2Faccessibility%2Faria-liveregions-notifications
Attachments
patch (13.88 KB, patch)
2015-07-29 17:07 PDT, Nan Wang 		cfleizach: review-
DetailsFormatted DiffDiff
patch (13.86 KB, patch)
2015-07-30 11:06 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-07-25 18:00:25 PDT
<rdar://problem/21998675>
Alexey Proskuryakov
Comment 2 2015-07-25 18:03:20 PDT
Added test expectations in r187394 (this means that test results are almost ignored, and we will only get a failure notification if they begin to crash).
Nan Wang
Comment 3 2015-07-29 17:07:05 PDT
Created attachment 257786 [details] patch
chris fleizach
Comment 4 2015-07-30 10:58:28 PDT
Comment on attachment 257786 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=257786&action=review just need a comment update. thanks > LayoutTests/ChangeLog:9 > + Previous tests were flaky that results were relying on a timer based notification. Fixed the tests by These tests were flaky because they relied on timer notification callbacks. Fixed these tests by using different objects to capture the notifications instead
Nan Wang
Comment 5 2015-07-30 11:06:57 PDT
Created attachment 257841 [details] patch
WebKit Commit Bot
Comment 6 2015-07-30 11:39:48 PDT
Comment on attachment 257841 [details] patch Clearing flags on attachment: 257841 Committed r187595: <http://trac.webkit.org/changeset/187595>
WebKit Commit Bot
Comment 7 2015-07-30 11:39:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.